Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

Issue 998001: code review 998001: ripple/proc: Proc endpoint uses quoting and escaping, o...

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by chris
Modified:
3 years, 6 months ago
Reviewers:
petar
CC:
gocircuit-dev_googlegroups.com, petar
Visibility:
Public.

Description

ripple: Multiple changes to semantics - directory-based

Original proc fixed to use quoted arguments.
Proc directory with multiple parsers, allowing full command option
specification.
Mutex directory implementation.
Channel directory implementation, including allowing buffered channels
and full blocking semantics as in Go.

Patch Set 1 #

Patch Set 2 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 3 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 4 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 5 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 6 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 7 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 8 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 9 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 10 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 11 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 12 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 13 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 14 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 15 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 16 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 17 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 18 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 19 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 20 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 21 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 22 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 23 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Patch Set 24 : diff -r 64e9bd769d59 https://code.google.com/p/gocircuit/ #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M CONTRIBUTORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEVGUIDE View 1 1 chunk +1 line, -1 line 0 comments Download
A src/circuit/kit/rh/ripple/chan2.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +253 lines, -0 lines 0 comments Download
A src/circuit/kit/rh/ripple/chandir.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +27 lines, -0 lines 0 comments Download
A src/circuit/kit/rh/ripple/chanread.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +142 lines, -0 lines 0 comments Download
A src/circuit/kit/rh/ripple/chanwrite.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +137 lines, -0 lines 0 comments Download
M src/circuit/kit/rh/ripple/cmd.go View 1 2 3 4 5 6 7 8 9 10 4 chunks +50 lines, -18 lines 0 comments Download
A src/circuit/kit/rh/ripple/mutexdir.go View 1 2 3 4 5 6 7 8 9 1 chunk +27 lines, -0 lines 0 comments Download
M src/circuit/kit/rh/ripple/proc.go View 1 2 3 4 5 6 4 chunks +9 lines, -6 lines 0 comments Download
A src/circuit/kit/rh/ripple/proc2.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +412 lines, -0 lines 0 comments Download
A src/circuit/kit/rh/ripple/procdir.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +28 lines, -0 lines 0 comments Download
M src/circuit/kit/rh/ripple/ripple_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/circuit/kit/rh/ripple/slab.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 7 chunks +46 lines, -22 lines 0 comments Download
A src/circuit/kit/rh/shargs/shargs.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +261 lines, -0 lines 0 comments Download
A src/circuit/kit/rh/shargs/shargs_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +147 lines, -0 lines 0 comments Download

Messages

Total messages: 3
chris
Hello p@gocircuit.org, petar (cc: gocircuit-dev@googlegroups.com, p@gocircuit.org), I'd like you to review this change to https://code.google.com/p/gocircuit/
3 years, 7 months ago #1
chris
Hello p@gocircuit.org (cc: gocircuit-dev@googlegroups.com, p@gocircuit.org), Please take another look.
3 years, 7 months ago #2
chris
3 years, 6 months ago #3
On 2014/01/21 16:25:57, chris wrote:
> Hello mailto:p@gocircuit.org (cc: mailto:gocircuit-dev@googlegroups.com,
mailto:p@gocircuit.org),
> 
> Please take another look.

And another look. I just uploaded the new channel directory implementation. Feel
free to play with it. It has buffering capability, uses the open/write/close -
open/read/close semantics discussed earlier, and blocks in the same way as
regular Go channels.

The next step is to work on select, but that will truly be in a separate CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1034:7cc4d015c6df-tainted