Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 34001: [release-branch.r1] circuit/sys/worker: Wait for ack fr...

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by petar
Modified:
4 years, 5 months ago
Reviewers:
petar
CC:
petar
Visibility:
Public.

Description

[release-branch.r1] circuit/sys/worker: Wait for ack from kicker process before
feeding stdin.

««« CL 33001 / 43219700f031
circuit/sys/worker: Wait for ack from kicker process before feeding stdin.
circuit/load/config: Print ack when executed in kicker mode.
circuit/kit/config: Add template functions for local OS and current repo.

Rename misc files to match OS keywords used in GOOS.

The problem in issue 16 was in the way we executing the remote kicker process.
We run ssh locally, which starts a remote sh, and then we feed into the STDIN
of the ssh process a shell script. The last command of the shell script is the
kicker execution. We then continue to feed the ssh's STDIN with content intended
for the STDIN of the kicker process.

It turns out that if the STDIN feed is sufficiently fast, the chunk intended
for the kicker process gets consumed by sh instead.

Fixes issue 16.

R=p
CC=gocircuit-dev, p
https://codereview-gocircuit-org.appspot.com/33001
»»»

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
~rietveld~placeholder~ View 0 chunks +-1 lines, --1 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1034:7cc4d015c6df-tainted